libp2p/jvm-libp2p

Test coverage of MultiplexHandler/Channel

開放

#27 建立於 2019年7月12日

 (2 則留言) (0 個反應) (0 位負責人)Kotlin (85 個分叉)auto 404
good first issue

倉庫指標

星標
 (359 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Cover the MultiplexHandler/Channel classes with unit tests. These are pretty central and non-primitive classes so they should be tested well. Primary attention should paid to closing child channels, so once the channel is created it must be finally closed. Child channels shouldn't leak. There are following close circumstances:

  • parent channel is closed
  • remote peer sends RESET signal
  • local peer sends RESET (on channel.close() invoked)
  • remote and local peers sends CLOSE (on channel.disconnect())

Child channels may be created with MultiplexHandler.createStream() asynchronously from any thread and prior to the parent channel is activated. Those cases should also be considered.

貢獻者指南