lexrus/LTMorphingLabel

Crippled performance, sometimes crashing on longer strings

Open

#18 建立於 2014年11月13日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Swift (8,150 star) (780 fork)batch import
bughelp wanted

描述

I've found that setting strings longer than about 50 characters crawls to a halt. Sometimes crashes. A simple fix would be to just not animate if the length is greater than a certain number. I attempted to do this by modifying the setter for the text variable, pausing the display link and setting super.text to the value if it was above a threshold. This sometimes works, but I think I'm missing something, as I still get issues with performance. Advice appreciated. Would love to use this in the next rev of Slated if I can get it reliable.

貢獻者指南

技術棧
swift
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
SwiftiOS development basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Start by examining the text property setter in LTMorphingLabel.swift and the display link logic. Look for the animation loop that processes each character. A possible fix is to add a threshold for string length and skip the morphing animation when exceeded, falling back to standard UILabel behavior. Ensure to test on longer strings to verify performance improvement.