lensapp/lens

Lens on MacOS ignores system option "Double-click a window's title bar to" minimize!

Open

#7,222 建立於 2023年2月23日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (22,003 star) (1,433 fork)batch import
area/macosbuggood first issuep2

描述

Describe the bug Lens on MacOS ignores system option "Double-click a window's title bar to" minimize!!!

To Reproduce Steps to reproduce the behavior:

  1. Set default option Double-click a window's title bar to minimize in System settings
  2. Click on Lens title bar
  3. See that Lens trying to change window size instead of minimize it

Expected behavior minimize when I choose to minimize in system settings

Screenshots

Environment (please complete the following information):

  • Lens Version: 2023.4.141316-latest
  • OS: Ventura M1 13.3.1 (a) (22E772610a)

貢獻者指南

技術棧
typescriptelectron
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of ElectronmacOS window behavior
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate how Lens creates its main window in Electron, likely in the main process file (e.g., src/main/index.ts). Look for BrowserWindow configuration, particularly the 'titleBarStyle' option. The default behavior should respect macOS system settings for double click to minimize, but Lens may override this. Check if there is a custom 'titleBarStyle' set to 'hiddenInset' or 'customButtonsOnHover', which can disable the default behavior. The fix may involve removing or changing that option, or adding a listener for the 'double click' event on the title bar to trigger minimize.