lbryio/lbry-sdk

Add type to supports data

Open

#919 建立於 2017年9月22日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Python (7,220 star) (500 fork)batch import
area: jsonrpchelp wantedlevel: 1type: improvement

描述

The Issue

Currently, when you list claim information (claim_list_mine/claim_show/resolve/claim_list) that shows supports, you can't tell if it's a classical support or a tip. We should add a type attribute to each support. If someone sends a tip to themselves, it's treated the same way as a classical support, so not sure which way it needs to be captured.

This will be an important field to report of off for search results and have available in the block explorer.

Expected behaviour

Support should show if it's a tip or not

Actual behaviour

Can't tell if support is a tip or classic support

貢獻者指南

技術棧
python
領域
blockchainbackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
Basic PythonUnderstanding of LBRY claim data model
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Review the current support data structure in the LBRY SDK, likely in files such as `lbry/schema/claim.py` or similar. Check existing comments in issue #919 for any proposed approaches. Determine where support objects are created and how the 'type' field should be integrated. Update serialization and deserialization to include the new field, ensuring backward compatibility.