lbryio/lbry-sdk

Ensure that default download directory is writable on daemon startup

Open

#3,270 建立於 2021年4月20日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Python (7,220 star) (500 fork)batch import
area: downloadsgood first issuehelp wantedtype: improvement

描述

Creating a new issue based on lbryio/lbry-sdk#877

  • Update ensure_directory_exists() to check that the directory is writable by the current process.
  • If it's not, return a useful error
  • Add tests to cover the case when
    • download directory does not exist
    • download dir exists but is not writable
    • dir exists and is writable
    • the path refers to a file not a directory

bonus: also check if disk is full when sdk starts. this check should be outside ensure_directory_exists(). it probably goes somewhere near here

貢獻者指南

技術棧
python
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Pythonfile system operationsunit testing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Update `ensure directory exists()` in `lbry/extras/cli.py` to verify the download directory is writable and return a useful error if not. Add unit tests covering the cases: directory does not exist, exists but not writable, exists and writable, and path is a file. Optionally, add disk space check near line 296. See related issue lbryio/lbry sdk#877 and existing test patterns in the repository.