lbryio/lbry-desktop

Add an option to build the the app using the elctron installed on the system

Open

#7,117 建立於 2021年9月17日

在 GitHub 查看
 (2 留言) (2 反應) (0 負責人)JavaScript (3,596 star) (412 fork)batch import
help wantediceboxlevel: 3type: new feature

描述

Is your feature request related to a problem? Please describe. I use ppc64le architecture and vanilla electron is not compatible... there are patched versions (of electron) available on some GNU/Linux distros like Void-ppc.

Describe the solution you'd like Basically adding an option to the build system that uses the distro's electron

Describe alternatives you've considered Use a precompiled version of electron on ppc64le?

貢獻者指南

技術棧
javascriptelectron
領域
desktopbuild system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Node.jsElectronBuild system (e.g., electron builder)
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the existing build configuration in package.json and the electron builder config. Research how other Electron apps implement a fallback to system electron (e.g., via environment variable `ELECTRON OVERRIDE DIST` or similar). Check the comment from the author for additional context. The solution likely involves modifying the build script to allow skipping the download of prebuilt Electron and instead use the system installed Electron binary.