lbryio/lbry-desktop

Flow type errors

Open

#2,024 建立於 2018年10月10日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (3,596 star) (412 fork)batch import
hacktoberfesthelp wanted

描述

We are currently trying to use Flow in every file. We have been slowly making progress but there are still a lot of errors.

If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation!

Some of the biggest offenders right now are in pages/file/view.jsx and anything with subscriptions.

To see all of the errors you can run ./node_modules/.bin/flow --color always

貢獻者指南

技術棧
javascriptreact
領域
developer experience
議題類型
chore
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of FlowNode.js and npm installed
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Start by running `./node modules/.bin/flow color always` in the project root to list all current errors. Focus on files like `pages/file/view.jsx` and areas related to subscriptions, as they are mentioned as major offenders. Fix simple type annotations first, using existing type definitions in the codebase as a reference. The maintainer offers LBC tokens as appreciation for contributions.