laravel/pint

Asymmetric Visibility Issue

Open

#383 建立於 2025年7月18日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)PHP (3,127 star) (189 fork)user submission
help wanted

描述

Pint Version

1.24.0

PHP Version

8.4

Description

There seems to be a bug with how asymmetric visibility is handled. The following class properties are fine:

  • public private(set) int $concurrency;
  • private int $concurrency;

However if I try to use the abbreviated form private(set) int $concurrency; as specified in the RFC then I get the error Cannot access offset of type null on SplFixedArray

Steps To Reproduce

Set a class property like private(set) int $propertyName and then run pint on the file.

貢獻者指南

技術棧
php
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PHP 8.4asymmetric visibility syntax
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the bug by examining how Pint parses property modifiers, specifically the handling of `private(set)` without explicit visibility. Look at the grammar file or lexer (likely in `src/` directory) that tokenizes and parses property declarations. The single comment on the issue may provide additional clues. Test with the provided reproduction case and ensure the fix aligns with the PHP RFC on asymmetric visibility.