lanl/singularity-eos

Should we remove forwarding references from PTE solvers?

開放

#438 建立於 2024年11月29日

 (4 則留言) (0 個反應) (0 位負責人)C++ (21 個分叉)auto 404
bugclean-updiscussionhelp wantedinterfacequestion

倉庫指標

星標
 (36 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

The segfault on HIP was caused by an access-out-of-scope error caused by passing pointers by reference into the PTE solvers. See #437 . Perhaps we should consider removing the forwarding references and pass only by value into the PTE solvers (with the exception of PTE Solver Base, which requires pass-by-reference as it is used as the first part of the derived class constructors).

Ping @jhp-lanl @jdolence @dholladay00 @mauneyc-LANL and @rbberger for feedback

貢獻者指南