laike9m/pdir2

XONSH support

開放

#29 建立於 2017年3月29日

 (5 則留言) (1 個反應) (0 位負責人)Python (48 個分叉)batch import
help wanted

倉庫指標

星標
 (1,321 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Hi,

I forked this repo and tried adding support to xonsh shell but i have problems with tests. Can someone more experienced with python/pytest look at these errors and tell me if I did something wrong (and what)?

Xonsh must be treated similarly to ptpython, so PrettyDir.__repr__() method should print self.repr_str not return it (just like for ptpython). So I made small changes in https://github.com/tkossak/pdir2/commit/24c43ba9bb05b732c66ae09e665dbb5dc4f0e95c and it works for me. The problem is with tests, which now return these errors. For me it seems like for xonsh and ptpython this assert: result.repr_str == repr(result) should always fail because __repr__() always returns null string for these shells. If so, why the tests work for ptpython and not for xonsh?

Thank you.

貢獻者指南