kubernetes/minikube

make it obvious in terminal for user if using docker-env

Open

#6,489 建立於 2020年2月4日

在 GitHub 查看
 (22 留言) (0 反應) (2 負責人)Go (31,799 star) (5,222 fork)batch import
co/docker-envgood first issuekind/documentationkind/featurelifecycle/frozenpriority/backlog

描述

I was thinking as part of the eval $(minikube docker-env) we could pass something that changes the terminal Prompt so it is obvious for the user they are usinf minikube's docker not their own docker.

maybe: something like:

medya@~ $ PS1="$PS1""(using minikube dockerd) $:"

that will try turn into

medya@~ $ (using minikube dockerd) $:

the minikube word would be profile name, this will also make it clear which profile's docker-env we are using.

helps with https://github.com/kubernetes/minikube/issues/6462 helps with https://github.com/kubernetes/minikube/issues/6437

also we could explicity set a ENV that says

USES_MINIKUBE_DOCKERD=PROFILE_NAME

貢獻者指南

技術棧
goshell
領域
clideveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic shell scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue proposes modifying the `eval $(minikube docker env)` command to change the terminal prompt or set an environment variable indicating the user is using minikube's Docker daemon. The implementation likely involves editing the `cmd/minikube/cmd/docker env.go` file or the associated shell script output. The suggestion is to add a line like `PS1="$PS1 (using minikube dockerd) $"` or export `USES MINIKUBE DOCKERD=PROFILE NAME`. Review the existing output format in the codebase and discuss which approach is cleaner. The issue has two assignees and many comments, indicating prior discussion but no resolution. Check the linked issues for additional context.