kubernetes/minikube

move viper calls from packages into cmd to improve testability/resusablitily

Open

#21,670 建立於 2025年9月30日

在 GitHub 查看
 (4 留言) (0 反應) (1 負責人)Go (5,222 fork)batch import
help wantedkind/cleanuppriority/important-soon

倉庫指標

Star
 (31,799 star)
PR 合併指標
 (平均合併 12天 19小時) (30 天內合併 43 個 PR)

描述

packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages

this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable

Originally posted by @medyagh in https://github.com/kubernetes/minikube/pull/21635#discussion_r2392461773

貢獻者指南