kubernetes/ingress-nginx

Feature Request: Allow disabling custom-http-errors per ingress

Open

#8,384 建立於 2022年3月23日

在 GitHub 查看
 (17 留言) (2 反應) (2 負責人)Go (15,199 star) (7,888 fork)batch import
good first issuehelp wantedkind/featureneeds-triagepriority/backlog

描述

When nginx.ingress.kubernetes.io/custom-http-errors is set to string off, overwrite the configmap value with an empty list instead of skipping it.

My current work-around is to use the 418 HTTP code (nginx.ingress.kubernetes.io/custom-http-errors: "418") because my apps aren't using it :wink:

貢獻者指南

技術棧
gokubernetes
領域
backendinfrastructure
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingKubernetes basicsingress nginx controller architecture
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the annotation parsing code for custom http errors, likely in internal/ingress/annotations/custom http errors. Modify the logic to treat the string 'off' as an empty list, overriding the configmap default. Check comments and linked PRs for prior discussion and ensure backward compatibility. Write tests for the new behavior.
Feature Request: Allow disabling custom-http-errors per ingress · kubernetes/ingress-nginx#8384 | Good First Issue