kubernetes/ingress-nginx

Distinguish wait-shutdown command from standard k8s SIGTERM

Open

#6,287 建立於 2020年10月6日

在 GitHub 查看
 (32 留言) (1 反應) (1 負責人)Go (15,199 star) (7,888 fork)batch import
good first issuehelp wantedkind/featureneeds-triagepriority/backlog

描述

As of v0.26.0, we can specify /wait-shutdown as a pre-stop hook in our deployment spec. As currently implemented, it sends SIGTERM to the nginx-ingress-controller process. https://github.com/kubernetes/ingress-nginx/blob/59a7f51cd4f0c41f214c520ca8b2a502946ed08e/cmd/waitshutdown/main.go#L29

Since SIGTERM is also what k8s sends when shutting down a pod, there is no way for us to really tell for sure from the logs whether the pre-stop hook was properly configured or not. For this reason, it would be better if wait-shutdown used a different signal.

/kind feature

貢獻者指南

技術棧
go
領域
devopscloud
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingKubernetes basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The change involves modifying the signal sent in cmd/waitshutdown/main.go at line 29 (link). Consider using a different signal like SIGQUIT or SIGUSR1, and ensure the documentation is updated. The issue has an assignee, so coordinate with them.
Distinguish wait-shutdown command from standard k8s SIGTERM · kubernetes/ingress-nginx#6287 | Good First Issue