area/clusterclasshelp wantedkind/featurepriority/important-longtermtriage/accepted
倉庫指標
- 星標
- (4,267 顆星)
- PR 合併指標
- (PR 指標待抓取)
描述
What would you like to be added (User Story)?
I think it would be good if we can go over Cluster.spec.topology and check if we have validation for all fields where it is appropriate.
Some examples:
- MachineHealthCheckTopology: we should have validation that if enable is set to false no MachineHealthCheckClass fields should be set
- MachineDeploymentStrategy: fields from MachineRollingUpdateDeployment should only be allowed to be set if Type is RollingUpdate
- The same check is missing in the MD webhook
We should in general check if there is any validation that we either have only in Cluster.spec.topology or the corresponding webhook of the core type (MD/MHC) and make sure they are sync.
This way we can avoid that the Cluster topology controller is creating MD/MHC objects which are already invalid based on their webhook
Detailed Description
Anything else you would like to add?
No response
Label(s) to be applied
/kind feature One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.