keystonejs/keystone-classic

findOneAndUpdate does not update tracked fields if upserted

Open

#4,442 建立於 2017年9月25日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (14,656 star) (2,288 fork)batch import
4.x candidatebughelp wanted

描述

Expected behavior

Calling findOneAndUpdate and creating a new document (while upsert is set to true) as a result of the function should also update the tracked createdAt and createdBy fields

Actual/Current behavior

It does not update createdAt or createdBy. They are both undefined.

Steps to reproduce the actual/current behavior

  1. Implement a findOneAndUpdate function call on a Keystone model.
  2. Pass it a first argument that represents a document that does not exist.
  3. Pass it a second argument that represents what data the document should have.
  4. Let the function run.
  5. Look at the document in the Admin panel, or retrieve the document some other way.
  6. createdAt and createdBy are both undefined.

I can manually instantiate these fields by passing createdAt and createdBy to the second argument of findOneAndUpdate, but the createdAt date will always update to be whenever the document was updated, rather than being maintained. Using findOneAndUpdate, I've no way of knowing whether this document exists before including this condition.

Environment

Software Version
Keystone 4.0.0-beta.5
Node 6.9.1

貢獻者指南

技術棧
javascriptnodejsmongodb
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with KeystoneJS modelsUnderstanding of MongoDB upsert behavior
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The bug occurs when `findOneAndUpdate` is called with `upsert: true` and creates a new document; the tracked fields `createdAt` and `createdBy` are not set. Investigate the implementation of `findOneAndUpdate` in KeystoneJS (likely in the `lib/` directory, e.g., `updateHandler.js` or similar). Look for how it handles upsert operations and whether it properly initializes tracked fields on document creation. Check if there is a separate `create` path that sets these fields, and ensure the upsert path calls it. Also, review any existing tests for `findOneAndUpdate` to confirm the expected behavior.