keystonejs/keystone-classic

4.0.0: Twig cache still set to true in developpment

Open

#4,268 建立於 2017年5月7日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (14,656 star) (2,288 fork)batch import
bughelp wanted

描述

When passing env to developpment, twig cache isn't set to false, I have to set it manually in node_modules/twig/twig.js. In fact whatever the setting of env and cache view, the twig cache is always set to true.

Software Version
Keystone 4.0.0
Node v7.3.0

貢獻者指南

技術棧
nodejs
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic Node.js knowledgeunderstanding of environment variables
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue states that Twig cache remains true in development mode regardless of env setting. Investigate how Keystone 4.0.0 reads environment configuration, particularly the `env` parameter and any Twig cache options. Look at the relevant files like `keystone.js` or the module loading of twig. Check if there's a missing condition to set `cache: false` when `env` is set to 'development'. Examine the current release's source code for how Twig is initialized. The fix likely involves ensuring the cache option is properly passed based on the environment.