keystonejs/keystone-classic

mime type error on file upload with FS adapter (when only specifying path)

Open

#4,017 建立於 2017年2月19日

在 GitHub 查看
 (5 留言) (0 反應) (1 負責人)JavaScript (14,656 star) (2,288 fork)batch import
bughelp wanted

描述

Steps to reproduce the behavior

  1. have a model with a field of type File and the file system adapter
  2. try to upload a file by calling model._.yourFileField.upload({path: specifiy your path})

Expected behavior

the file appears in the directory specified in the file system adapter

Actual behavior

an error occurs: mime is not a function

it happens because in lib/storage/index.js line 120 the mime type is tried to be evaluated when it wasn't specified in the file parameter, but the call has to be mime.lookup(file.path)

貢獻者指南

技術棧
javascriptnodejsexpress
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Node.jsKeystoneJS file uploads
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The bug is in lib/storage/index.js at line 120 where `mime(file.path)` is used instead of `mime.lookup(file.path)`. The fix is straightforward: replace `mime(file.path)` with `mime.lookup(file.path)`. No linked PRs or recent comments suggest any blockers. The assignee may have a solution, but the issue is open. Ensure the fix aligns with the existing codebase style and testing practices.
mime type error on file upload with FS adapter (when only specifying path) · keystonejs/keystone-classic#4017 | Good First Issue