keithamus/jwerty

Key binding not working on IE

Open

#5 建立於 2011年10月24日

在 GitHub 查看
 (15 留言) (0 反應) (0 負責人)JavaScript (1,214 star) (117 fork)batch import
bughelp wanted

描述

Hi,

First of all gratz for this awesome lib ! Nevertheless i cant make it work on internet explorer due to the event.metaKey property which is 'undefined' on IE. Thus each property in the jwertyCode object are not equals to those in the event object :

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
// ...except for jwertyCode.jwertyCombo...
 if (p !== 'jwertyCombo' && event[p] !== jwertyCode[n][p]) returnValue = false;
 }

I temporarily bypassed this IE problem by removing the metaKey references in your lib.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptbrowser events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue is that `event.metaKey` is undefined in Internet Explorer, causing the property comparison loop to fail. The fix likely involves either adding a guard against undefined properties in the loop or removing `metaKey` from the event code object for IE. Look at the source code in the repository for the loop described in the issue and consider a conditional check. The comments may contain additional context or suggested fixes.