jwerty.is() not working in FF · keithamus/jwerty#38

(0 留言) (0 反應) (0 負責人)JavaScript (1,214 star) (117 fork)batch import

help wanted

描述

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
    // ...except for jwertyCode.jwertyCombo...
    if (p !== 'jwertyCombo' && event[p] != jwertyCode[n][p]) returnValue = false;
}

I'm trying to check for key binding when clicking on an element but jwerty.is() does return false for 'shift', 'cmd' & 'alt'. After some minutes of debugging I've found the problem: You're getting the originalEvent which is in that case [object MouseEvent] and has no property keyCode for that reason. Therefore the result is always false. I'm not sure if there is a solution for this problem in FF, but it is working fine in Chrome. Thanks for this wonderful library!

貢獻者指南

技術棧: javascript
領域: frontend
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Understanding of DOM eventsKnowledge of cross browser event handling
新手友善度: 50
研究方向: The issue is that jwerty.is() fails in Firefox when a MouseEvent is passed instead of a KeyboardEvent because MouseEvent lacks keyCode. To fix, check the event type (event.type) and handle accordingly. Look at how jwerty internally uses jwertyCode and consider using event.key or event.which as fallbacks. Reference the Mozilla Developer Network for event handling differences.