kaldi-asr/kaldi

"bc" is not linux native , you should add some check

Open

#2,954 建立於 2018年12月31日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Shell (15,392 star) (5,359 fork)batch import
enhancementhelp wantedstale

描述

low priority issue , it is not a real issue to debug this error , and install bc afterwards , but nevertheless , this is not a native linux command . you should add some warning in , maybe in run.sh for all the diarizations recipe , or in the script itself.

https://github.com/kaldi-asr/kaldi/blob/3e77220b3297831c3a370169580b880461897682/egs/callhome_diarization/v1/diarization/extract_ivectors.sh#L95

貢獻者指南

技術棧
shell
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic shell scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue requests adding a check for the 'bc' command in the shell scripts, specifically in the file `egs/callhome diarization/v1/diarization/extract ivectors.sh`. Look at line 95 where 'bc' is used. Add a check at the beginning of the script using `command v bc` or similar to verify bc is installed. If not, print a warning and exit or install it. Consider also checking other scripts in the same recipe. The maintainers have not responded, so the fix is open for contribution.