kaldi-asr/kaldi

Fix registering of CuAllocatorOptions

Open

#2,929 建立於 2018年12月21日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)Shell (15,392 star) (5,359 fork)batch import
bughelp wantedstale

描述

Currently it seems we register the global options but don't call the SetOptions() function. There is no need for the global options-class variable, we can use a local one in each binary that registers the options. @desh2608 can you please do this? Ask one of the other students if you don't know how.

貢獻者指南

技術棧
cppshell
領域
backendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++Kaldi framework
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is about fixing the registration of CuAllocatorOptions. The current code registers global options but does not call SetOptions(). The fix is to remove the global variable and use a local CuAllocatorOptions instance in each binary that registers options, then call SetOptions(). The relevant code is likely in the Kaldi source where CuAllocatorOptions is defined. Check comments from maintainer @desh2608 for further guidance. No linked PRs exist.