jupyterlab/jupyterlab

Make typescript compilation more apparent for new contributors

Open

#5,840 建立於 2019年1月6日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TypeScript (13,454 star) (2,937 fork)batch import
documentationgood first issuequestion

描述

When setting up to develop with Jupyter, I was not able to apply modifications to the packages directory while running in watch mode, jupyer lab --dev-mode --watch. Typescript changes would make the contents of my launcher not load in the Jupyter lab web application. Eventually, I read deeper into other developer documentation and found that I needed to compile typescript separately, or I would need to run jlpm run build after every typescript change. Would it be possible to either 1) integrate the typescript build into the webpack watch or 2) simply put this information in contributing.md to avoid confusing new contributors? Also, I still seem to have an issue if I do not build using jlpm run build for typescript changes.

貢獻者指南