jupyterhub/repo2docker

Launching docker container in interactive mode

Open

#599 建立於 2019年3月2日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (1,544 star) (358 fork)batch import
enhancementgood first issuehacktoberfesthelp wanteduser-support

描述

I was expecting repo2docker https://github.com/binder-examples/conda-freeze /bin/bash to give me a shell inside the container. Instead it builds the image and then exits straight away.

I think this is because we would have to do the equivalent of docker run -it <image> /bin/bash but don't. Should we add a --interactive CLI flag that turns on this behaviour?

Note: a solution to this is outlined in https://github.com/jupyter/repo2docker/issues/599#issuecomment-483402517. This would be a good way to get involved with contributing to repo2docker and something to help out with in general.

貢獻者指南

技術棧
pythondocker
領域
clidevops
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Python programmingDocker fundamentalsCLI argument parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
First, review the solution outlined in comment https://github.com/jupyter/repo2docker/issues/599#issuecomment 483402517 to understand how to add the interactive flag. Then locate where CLI arguments are defined, likely in the repo2docker CLI entry point (e.g., main .py or cli.py). Add a boolean flag interactive that, when set, passes the it options to the docker run command inside the container startup logic. Update any existing tests or add a new test for the flag. Ensure the documentation and help string are updated accordingly.