jupyterhub/repo2docker

Always convert line endings in `postBuild` to unix

Open

#263 建立於 2018年3月15日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (1,544 star) (358 fork)batch import
enhancementgood first issuehacktoberfesthelp wanted

描述

We should filter/convert the line endings in postBuild as that seems to cause problems (see https://github.com/jupyter/repo2docker/issues/237#issuecomment-373446647)

Is there a docker option to have it convert line endings on COPY or do we have to convert it before copying or add a tool like dos2unix to the container?

貢獻者指南

技術棧
pythondocker
領域
backenddevops
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Knowledge of DockerLine ending concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the linked comment in issue #237 to understand the exact problem. Check if Docker has a line ending conversion option during COPY. If not, explore converting the postBuild file before copying it into the container or adding a tool like dos2unix. The solution should ensure Unix line endings are used consistently.