jsx-eslint/eslint-plugin-react

no-direct-mutation-state on references

Open

#747 建立於 2016年8月7日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

Currently no-direct-mutation-state doesn't seem to support hunting down (even simple cases) where a reference to this.state is being used. Luckily I caught my co-workers bug while doing code review but it would be pretty sweet if the rule could detect this case too.

const { product } = this.state;
product.name = name;

I've never written an eslint rule before so I have no clue if this is even possible, if it is, please let me know and I might give it a stab when I have some more free time.

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of ESLint rulesAST traversal
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Examine the existing rule implementation in src/rules/no direct mutation state.js to understand how it currently detects direct mutations of this.state. Adapt the logic to track references to state properties, e.g., when const { product } = this.state; is followed by product.name = name;. Consider using ESLint's no param reassign rule as inspiration. Check the issue comments for any suggestions and test with the provided example.
no-direct-mutation-state on references · jsx-eslint/eslint-plugin-react#747 | Good First Issue