[Bug]: react/jsx-no-leaked-render reports error on boolean values and tries to convert them · jsx-eslint/eslint-plugin-react#3908

(2 留言) (5 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import

enhancementhelp wantedtypescript

描述

Is there an existing issue for this?

I have searched the existing issues and my issue is unique
My issue appears in the command-line and not only in the text editor

Description Overview

Using following setup:

'react/jsx-no-leaked-render': ['error', { validStrategies: ['ternary', 'coerce'] }]

The code reports error even though emptyCollection is already boolean value. I understand that the plugin does not take into account actual types that TS provides.

Running lint command reports an issue unless I convert the code to this 👇

Is there a way to prevent this from being "fixed" since it's already a boolean value?

Expected Behavior

eslint-plugin-react version

v7.37.4

eslint version

v9.18.0

node version

v22.13.0

貢獻者指南

技術棧: javascriptreact
領域: frontendtooling
議題類型: bug
難度: 3
預計時間: 1-2 days
活動狀態: fresh
清晰度: clear
前置要求: ESLint plugin developmentReact JSXAST understanding
新手友善度: 60
研究方向: Examine the rule implementation at `lib/rules/jsx no leaked render.js`. Review the test file for this rule (likely `tests/lib/rules/jsx no leaked render.js`) to understand current test cases. The core issue is that the rule incorrectly flags boolean variables when using the ternary or coerce strategy. Determine if the rule should rely on TypeScript type annotations (using `@typescript eslint/parser`) or if a simpler heuristic (e.g., checking that the expression is a boolean literal or `typeof x === 'boolean'`) can be applied. Check the comments in issue #3908 for any maintainer suggestions.