jsx-eslint/eslint-plugin-react

[Enhancement]: jsx-handler-names reports error with inline ternary conditional callbacks

Open

#3,855 建立於 2024年11月20日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Conditionally applying callback functions with inline ternary statements violates the rule, even when the condition will satisfy the rule.

<MyComponent
  onClick={isClickDisabled ? undefined : handleClick}
/>

ESLint: Handler function for onClickNext prop key must be a camelCase name beginning with 'handle' only(react/ jsx-handler-names)

Expected Behavior

If there is an inline ternary condition and it returns the properly named function, it should pass.

eslint-plugin-react version

v7.37.2

eslint version

v8.57.0

node version

v20.17.0

貢獻者指南

技術棧
javascriptreact
領域
frontendtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptESLint plugin developmentReact event handlers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the implementation of the `jsx handler names` rule in `lib/rules/jsx handler names.js`. Look for where the prop value is checked for a handler pattern. The rule currently fails on ternary expressions; research how to properly evaluate ternary nodes (ConditionalExpression) to check if both branches are valid handlers or if one is undefined/valid. Check how other rules handle similar patterns, e.g., `jsx no target blank`. After understanding, propose a fix that allows the ternary expression if it returns a properly named handler or undefined.