jsx-eslint/eslint-plugin-react

[jsx-handler-names] Option to enforce only for class methods

Open

#358 建立於 2015年12月11日

在 GitHub 查看
 (6 留言) (5 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wantedrule

描述

This is a useful rule, but it can sometimes get annoying when I want to use a prop or a method from a library directly as a handler. I think the real benefit to the rule is to force me to name my component's methods appropriately, but as it currently works, I sometimes need to do silly things like const handleSelect = props.entities.toggleItem;.

I would really like an option which prevents:

<MyComponent onChange={this.doSomething} />

// or in a stateless component:

<MyComponent onChange={doSomething} />

but still allows:

<MyComponent onChange={library.doSomething} />

<MyComponent onChange={this.props.doSomething} />

// or in a stateless component:

<MyComponent onChange={props.doSomething} />

Does that make any sense?

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experiencefrontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of ESLint plugin developmentFamiliarity with React and JSX
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue requests a new option for the 'jsx handler names' rule to allow non method handler references from props or library objects while still enforcing naming for class methods. The rule's source code is in the eslint plugin react repository; look for the rule definition in the 'lib/rules' directory. There are no linked PRs but there are 6 comments that may contain further discussion. To implement, consider adding a configuration option like 'ignoreMemberExpressions' or 'allowNonMethodHandlers' and update the rule logic accordingly.