jsx-eslint/eslint-plugin-react

[Bug]: `react/prop-types` false positive when component is a value of capitalized property in class

Open

#3,534 建立於 2023年2月21日

在 GitHub 查看
 (9 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Weird error: image

import React from 'react';

class SomeComponent {
	column = {
		Cell: ({ original }: { original: string }) => <span>{original === 'bla' ? 'bla' : 'bla'}</span>,
	};
}

error    'original' is missing in props validation  react/prop-types

eslint myfile.tsx

Expected Behavior

Not to throw error

When I change Cell to cell - the error is gone. When I avoid using destructuring - the error is also gone.

eslint-plugin-react version

v7.32.2

eslint version

v8.34.0

node version

v18.14.1

貢獻者指南

技術棧
javascripttypescriptreact
領域
frontendtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin architectureReact prop types ruleTypeScript basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Start by examining the `react/prop types` rule implementation in `lib/rules/prop types.js`. Look for how the rule identifies React components and validates props. The bug occurs when a component is assigned to a capitalized property (e.g., `Cell`) in a class instance, causing a false positive. Investigate the logic that determines whether a variable is a component vs. a regular prop. Check the issue comments for any maintainer hints or related PRs. Focus on the expression handler and see if the capitalization triggers an incorrect assumption that the value is a component.