jsx-eslint/eslint-plugin-react

`react/no-unstable-nested-components` does not allow ignoring only object properties

Open

#3,482 建立於 2022年11月4日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

I would like to keep this rule active but disable it for object properties, I have this:

function MyComponent() {
  return (
    <p>
      {intl.formatMessage(messages.allSelected, {
        size: selectedEvents.size,
        b: chunks => <b>{chunks}</b>, // <-- report error here without `allowAsProps`
      })}
    </p>
  );
}

But adding the allowAsProps: true option allows me to do things like this:

<Dropdown
  Trigger={({ onClick }) => ( // <-- don't report error here with `allowAsProps`
    <button type="button" onClick={onClick}>
      Bla bla
      <span className="caret" />
    </button>
  )}
>
  {/* ... */}
</Dropdown>

貢獻者指南

技術棧
javascriptreact
領域
frontendtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin developmentAST traversalJavaScriptReact
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the implementation of the `react/no unstable nested components` rule in the eslint plugin react repository, particularly the handling of the `allowAsProps` option. The goal is to add a new option that only ignores object properties (object values) rather than all props. Key files to examine: the rule definition file (likely `lib/rules/no unstable nested components.js`) and its tests. Consider adding a new option like `allowObjectProperties` or modifying the existing `allowAsProps` to be more granular. No linked pull requests or maintainer comments are present, so the feature request is open for implementation.