jsx-eslint/eslint-plugin-react

react/no-unused-prop-types false positive when using memo

Open

#3,403 建立於 2022年9月5日

在 GitHub 查看
 (6 留言) (4 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

Here's an example using CRA

Expected: No warning

Actual:

  • npm run lint
eslint-example/src/App.js
  23:3  warning  'showFirst' PropType is defined but prop is never used  react/no-unused-prop-types

This started when going from version 7.30.0 to 7.30.1.

  • If I remove memo the warning goes away
  • If I wrap the ternary in the return with a fragment the warning goes away but then I'd have to silence react/jsx-no-useless-fragment so not helpful either.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of ESLint rule structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
The issue is a false positive in the react/no unused prop types rule when a component is wrapped in React.memo. The rule started incorrectly warning after version 7.30.0. Investigate the rule's source code in the lib/rules/no unused prop types.js file, particularly the logic that handles wrapped components. Look for changes between versions that might have introduced this regression. Review the comments for additional test cases and consider reproducing the issue with the provided example.