jsx-eslint/eslint-plugin-react

prop-types Validating external propTypes (eg. decorators)

Open

#322 建立於 2015年11月19日

在 GitHub 查看
 (13 留言) (7 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wantedrule

描述

This is something that comes from loggur/react-redux-provide#1 as propTypes are used to actually define data that will be provided to the component like this:

@provide({
  list: PropTypes.arrayOf(PropTypes.object).isRequired,
  pushItem: PropTypes.func.isRequired
})
export default class GoodTimes extends Component {
}

That doesn't coop well with this rule unfortunately. I am wondering if there is a way how to analyze this and read propTypes from higher-order component / decorator also.

I have noticed some undocumented customValidators, but I am not sure how does that works. If I understand correctly it accepts list of props that will be ignored?

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of ESLint plugin architectureFamiliarity with React propTypesKnowledge of decorators syntaxExperience parsing AST with ESLint
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current prop types rule implementation in eslint plugin react, specifically how it validates PropTypes on class components and how decorators are handled by ESLint's parser. Look at the linked issue loggur/react redux provide#1 for context. Check if there are any existing discussions or attempted PRs. Consider using AST selectors to detect PropTypes defined in decorators and integrate them into the validation logic.
prop-types Validating external propTypes (eg. decorators) · jsx-eslint/eslint-plugin-react#322 | Good First Issue