jsx-eslint/eslint-plugin-react

react/prop-types false positive “is missing in props validation” for extended component types

Open

#3,159 建立於 2021年12月15日

在 GitHub 查看
 (2 留言) (4 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
help wantedtypescript

描述

I’m building a component with antd-style subcomponent access. I.e. I want to be able to do <Columns><Columns.Block/></Columns>.

I made two attempts, both of which complained about “… is missing in props validation” once I replaced a bare FC<…> with something else:

By extending FC<…>:

const Block: FC<…> = (…) => …

export interface ColumnProps { … }
export interface ColumnsComponent extends FC<ColumnsProps> {
  Block: typeof Block
}
const Columns: ColumnsComponent = (…) => …
Columns.Block = Block

and inline:

const Block: FC<…> = (…) => …

export interface ColumnProps { … }
const Columns: FC<ColumnsProps> & { Block: typeof Block } = (…) => …
Columns.Block = Block

貢獻者指南

技術棧
javascripttypescriptreact
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin development basicsReact prop types ruleTypeScript type extension patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the prop types rule source in `lib/rules/prop types.js`. Understand how it currently extracts prop types from type annotations. The false positive occurs when the component type is an extension of FC (e.g., FC<Props> & { Block: typeof Block }). Look at the rule's handling of intersection types. Review any existing tests for similar patterns. Consider adding a test case with the provided code and adjusting the rule logic to correctly handle extended component interfaces.
react/prop-types false positive “is missing in props validation” for extended component types · jsx-eslint/eslint-plugin-react#3159 | Good First Issue