jsx-eslint/eslint-plugin-react

prop-types: children and React.VFC

Open

#2,913 建立於 2021年2月1日

在 GitHub 查看
 (14 留言) (3 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
help wantedtypescript

描述

There is now a way to properly communicate the absence of the children prop at the TypeScript level: React.VFC (vs React.FC). React.VFC aka React.VoidFunctionComponent does not allow children prop, the prop-types rule should derive the presence/absence of children from the underlying TypeScript types (when used with TypeScript).

Related: #7.

貢獻者指南

技術棧
javascripttypescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of React TypeScript typesFamiliarity with eslint plugin react internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue requests extending the prop types rule to support React.VFC, which does not allow children prop. Start by reviewing the existing prop types rule implementation (likely in lib/rules/prop types.js) and the related issue #7 for context. Look for how the plugin currently infers type definitions from TypeScript. Consider adding detection of React.VFC (or React.VoidFunctionComponent) and updating the logic to recognize that these types imply no children prop. The solution involves parsing TypeScript types within the AST and checking the component's type reference.
prop-types: children and React.VFC · jsx-eslint/eslint-plugin-react#2913 | Good First Issue