jsx-eslint/eslint-plugin-react

warn when using setState in constructor

Open

#2,371 建立於 2019年8月5日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
acceptedhelp wantednew rule

描述

Obviously it could have been used by functions called from the constructor, but using setState in constructor is always an issue in react and causes a warning in debug mode.

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsESLint rule creation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests a warning when setState is called directly inside a constructor. Research existing rules in the eslint plugin react repo, such as no unused state, for implementation patterns. The new rule should traverse AST nodes to identify constructors (e.g., ClassBody with MethodDefinition kind 'constructor') and detect CallExpression to setState. Consider also tracking calls to functions invoked from the constructor. Review the 3 comments on the issue for additional context or pitfalls. Then implement the rule in a new file under rules/ and add tests.