jsx-eslint/eslint-plugin-react

prefer-stateless-function should not check a .d.ts for a Stateful Component

Open

#2,296 建立於 2019年5月31日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wantedtypescript

描述

Imagine that we have a stateful react component and is about to creating a declaration file d.ts for the .js/.jsx file.

declare class StateCom extends React.Component<Props> {}
export default StateCom;

and error/warning occurs that: Component should be written as a pure function eslint(react/prefer-stateless-function)

How can we handle this since the component is a truly Component with state instead of a functional component?

貢獻者指南

技術棧
javascripttypescriptreact
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of ESLint plugin developmentunderstanding of TypeScript declaration files
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the rule implementation in `lib/rules/prefer stateless function.js`. Look for how the rule checks file extensions or AST node types to determine if a component is stateful. The fix should likely skip `.d.ts` files or skip class declarations within them. Check existing tests in `tests/lib/rules/prefer stateless function.js` for patterns. Consider adding a test case with a `.d.ts` file. Review any comments in the issue for maintainer input.