jsx-eslint/eslint-plugin-react

[ESLint v5.9.0] Fix types

Open

#2,039 建立於 2018年11月9日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

A new option was added to ESLint. Reference: https://eslint.org/blog/2018/11/eslint-v5.9.0-released#the-fix-type-option

Should we start supporting this? If so, looks like "layout" is pretty obvious, but "problem" vs "suggestion" could be harder to tell. Or should we just set all recommended non-layout rules to "problem"?

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ESLint plugin basicsunderstanding of ESLint fix types
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the ESLint v5.9.0 release notes for the fix type option (https://eslint.org/blog/2018/11/eslint v5.9.0 released#the fix type option). Examine existing rules in the plugin (e.g., in src/rules/) to understand current meta.fixable values. Determine a strategy for categorizing rules into 'layout', 'problem', or 'suggestion' based on rule intent. Decide whether to set all recommended non layout rules to 'problem' or require per rule analysis. Implement changes to each rule's meta.fixable property and add corresponding test updates.