jsx-eslint/eslint-plugin-react

react/prefer-stateless-function works different than described in docs

Open

#1,901 建立於 2018年7月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

For the react/prefer-stateless-function rule the docs for ignorePureComponents option states:

When true the rule will ignore Components extending from React.PureComponent that use this.props or this.context.

Actually it also ignore every PureComponent that use not only props or context, but ignores every component that use this. If this is not intended I prepared a fix (GH-1902), otherwise it makes sense to update the docs.

貢獻者指南

技術棧
javascriptreact
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ESLint rule developmentReact component patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the rule implementation in lib/rules/prefer stateless function.js and its test suite to confirm the behavior discrepancy. Check the linked PR (GH 1902) for a proposed code fix and ensure it aligns with the intended rule logic. Evaluate whether updating the documentation to match current behavior is simpler than fixing the code. Since the issue is old and has no recent activity, consider reaching out to maintainers for guidance on the preferred resolution path.