jsx-eslint/eslint-plugin-react

Rule proposal: no layout thrashing

Open

#1,889 建立於 2018年7月20日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
acceptedhelp wantednew rule

描述

I've seen a lot of seemingly simple code lead to layout thrashing and performance problems that could have been statically detected and avoided. It would be nice to have a rule that could flag some of these scenarios.

I think it might make sense to take Paul Irish's list of what causes layout/reflow, and write a rule that flags when these happen synchronously in places like componentDidMount, render, and componentWillReceiveProps, etc.

Example:

class Foo extends React.Component {
  constructor(props) {
    super(props);

    this.state = {
      windowHeight: window.innerHeight, // <-- this forces layout
    };
  }
  // ...
}

Thoughts?

貢獻者指南

技術棧
javascriptreact
領域
frontendperformance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
React lifecycleESLint rule structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
This issue proposes a new ESLint rule to detect layout thrashing in React components. To proceed, review Paul Irish's list of layout triggering properties and methods, and identify which are commonly used synchronously in lifecycle methods like componentDidMount and render. Consider existing similar rules in the plugin for pattern reference. The main challenge is determining when the reads are harmful; a static analysis approach would need to track reads that force layout. Look at the plugin's source code structure for adding a new rule.