jsx-eslint/eslint-plugin-react

New Rule: Prevent boolean values for unknown props

Open

#1,695 建立於 2018年2月15日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wantedreact 16

描述

React 16 does not ignore Boolean values for unknown props anymore.

So while this code "worked" in react 15:

<div onClick={!disabled && onClick}/>

It would try to assing false to the DOM elements onClick handler when disabled === true (which would be ignored by the browser).

React 16 will print an error message in the console though.

How about a rule that does not allow boolean results for unknown props?

See https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html#changes-in-detail "Non-boolean attributes with boolean values"

貢獻者指南

技術棧
javascriptreactnodejs
領域
frontendtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React JSXESLint rule development
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Implement a new ESLint rule that flags boolean values assigned to non boolean DOM props. Study the existing rule 'no unknown property' in lib/rules/ for pattern. The rule should check JSX attributes where the value is a boolean and the prop name is not a known boolean attribute. Test cases should be added in tests/lib/rules/. Reference the React 16 blog post for the behavior change. Check comments in issue #1695 for any additional guidance.