jsx-eslint/eslint-plugin-react

Object composition in propTypes causes 'default-props-match-prop-types' error

Open

#1,674 建立於 2018年2月2日

在 GitHub 查看
 (13 留言) (15 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bugenhancementhelp wanted

描述

Consider the following functioning example:

elementEventCardBaseShape = {
  calendarLink: mediaFileShape,
  mapLink: PropTypes.string,
  startDate: PropTypes.string,
  locationName: PropTypes.string,
  street: PropTypes.string,
  city: PropTypes.string,
  region: PropTypes.string
};

ElementEventCard.propTypes = {
  ...elementEventCardBaseShape,
  lang: PropTypes.string
};

ElementEventCard.defaultProps = {
  lang: 'en',
  calendarLink: {},
  mapLink: '',
  startDate: '',
  locationName: '',
  street: '',
  city: '',
  region: ''
};

Where all but 'lang' throw an error for said prop supposedly having no matching propType. Am I missing something?

貢獻者指南

技術棧
reactjavascript
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reacteslint plugin reactPropTypes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the rule `default props match prop types` in eslint plugin react, specifically how it resolves propTypes when object spread (e.g., `...elementEventCardBaseShape`) is used. Look at the rule source code in `lib/rules/default props match prop types.js` and trace the logic for detecting propTypes definitions. Consider similar issues or PRs that may have explored this. The issue reports a false positive when defaultProps are provided for props defined via spread.