jsx-eslint/eslint-plugin-react

no-array-index-key not triggered when spreading props

Open

#1,625 建立於 2017年12月24日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
enhancementhelp wanted

描述

There's no warning or error when doing something like this:

people.map(({ name, email }, key) => {
  const props = {
    key,
    name,
    email,
  };

  return <Person {...props} />;
});

I realize this is a bit of an edge case, but maybe we can find a way to catch these uses as well.

貢獻者指南

技術棧
javascriptreact
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with ESLint plugin structureUnderstanding of AST traversal
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue is about the `no array index key` rule not triggering when the key is spread via props. To fix this, examine the rule implementation in `lib/rules/no array index key.js`. The rule currently checks for `key` prop directly on JSX elements but does not detect `{...props}` spreading. Investigate how other rules handle prop spreading, and consider adding a helper to look for `key` in object expressions used in JSX spread attributes. Also check the rule's test file (`tests/lib/rules/no array index key.js`) for existing test cases and add new ones covering spread scenarios.