jsx-eslint/eslint-plugin-react

react/no-direct-mutation-state doesn't catch all cases

Open

#1,418 建立於 2017年9月8日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
help wanted

描述

  const { model } = this.state;
  model.rating = rate;

In this case eslint won't show any errors.

貢獻者指南

技術棧
javascriptreact
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ESLint rulesUnderstanding of React's state mutation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
42
研究方向
The issue reports that the rule `react/no direct mutation state` fails to flag cases where a nested property of `this.state` is mutated indirectly, e.g., `const { model } = this.state; model.rating = rate;`. To fix this, examine the existing rule implementation in `lib/rules/no direct mutation state.js` and modify it to detect assignments to properties of objects retrieved from `this.state`. A possible approach is to track when a variable is assigned a value from `this.state` and then flag any subsequent member assignments on that variable. See issue #1418 and the rule's source code for details.
react/no-direct-mutation-state doesn't catch all cases · jsx-eslint/eslint-plugin-react#1418 | Good First Issue