jsx-eslint/eslint-plugin-react

Rule idea: no-mutation-props

Open

#1,113 建立於 2017年3月14日

在 GitHub 查看
 (6 留言) (8 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
help wantednew rulequestion

描述

A component is never meant to modify its own props (https://facebook.github.io/react/docs/components-and-props.html#props-are-read-only).

I suggest we had a no-mutation-props rule to check for mutations of a components own props. It looks like we could likely copy the logic used in no-direct-mutation-state.js.

貢獻者指南

技術棧
javascriptreactnodejs
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin developmentReact props immutabilityAST manipulation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Look at the existing rule no direct mutation state.js in the same repository (lib/rules/no direct mutation state.js) to understand the logic for detecting mutations. Adapt it to detect mutations of props instead of state. Consider edge cases like nested props and object spread. Review the React documentation link provided in the issue. Check the issue comments for any additional discussion on implementation details or scope.