jsx-eslint/eslint-plugin-react

Should react/no-did-mount-set-state trigger on ES2017 async componentDidMount?

Open

#1,110 建立於 2017年3月10日

在 GitHub 查看
 (16 留言) (21 反應) (0 負責人)JavaScript (8,630 star) (2,797 fork)batch import
bughelp wanted

描述

The rule react/no-did-mount-set-state triggers error on async componentDidMount function for a deferred setState. Basically, this.setState() is being called here after an async operation has been completed. It is not re-rendering straight after mounting, but only after some data has been retrieved from a server. Does it make sense to error on this?

async componentDidMount() {
    try {
      await someAsyncOperation();
    } catch (e) {
      this.setState({errorMessage: 'Failed to load data!'});
    }
  }

貢獻者指南

技術棧
javascriptreact
領域
frontendtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLintReactasync/await
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the rule implementation in src/rules/no did mount set state.js. Determine if the rule's logic should distinguish synchronous setState calls in componentDidMount from asynchronous ones where setState is called after an await. Review the discussion comments for proposed solutions and consider adding an option to allow async patterns. The fix may involve modifying the rule to only warn on synchronous setState calls.
Should react/no-did-mount-set-state trigger on ES2017 async componentDidMount? · jsx-eslint/eslint-plugin-react#1110 | Good First Issue