jshint/jshint

/* global */ list accepts spaces in identifiers

Open

#3,208 建立於 2017年11月9日

在 GitHub 查看
 (9 留言) (0 反應) (0 負責人)JavaScript (8,937 star) (1,757 fork)batch import
P3good first issue

描述

/*global window, document, require, externData alert, machineID:true, externJSON $*/

produces the output

'externData alert' is defined but never used (W098)

except that isn't a legal identifier because of the embedded space. (It should have been "externData, alert' but sloppy typing on my part, which led to the warning.)

The warning should be more along the lines of 'Illegal JavaScript identifier,' should it not?

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
familiarity with jshint source codeunderstanding of JavaScript identifiers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the parsing of `/*global */` directives in jshint; the likely location is in the lexer or a related module where identifiers are extracted from comments. Look for how spaces are handled when splitting identifiers; the current code likely splits on commas but does not validate each token as a valid JavaScript identifier. A regex or helper function like `isValidIdentifier` can be used to detect illegal identifiers like 'externData alert' and report an appropriate error.