jquery-form/form

Enable AND disable the `consistent-this` rule

Open

#553 建立於 2018年7月12日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (5,209 star) (2,199 fork)batch import
featurehelp wanted

描述

https://github.com/jquery-form/form/blob/master/src/jquery.form.js#L138

This line causes problems if we are concatenating with several other vendor pieces of code.

The only way to resolve this is to use dist/jquery.form.min.js, however it'd be great if we had a non-minified version in the dist folder as well 👍

貢獻者指南

技術棧
javascript
領域
frontendbuild system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the build configuration (likely Gruntfile or package.json scripts) in the repository. Add a task to copy the non minified 'src/jquery.form.js' into the 'dist' folder, possibly with a version suffix. Ensure that the concatenation issue mentioned in line 138 is resolved by using the non minified version in the distribution.
Enable AND disable the `consistent-this` rule · jquery-form/form#553 | Good First Issue