josdejong/mathjs

Functions do not recon with `config.number` when converting a string into a numeric type

Open

#3,206 建立於 2024年5月29日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (13,832 star) (1,298 fork)batch import
bughelp wanted

描述

It's a bit of an edge case, but for example:

math.config({number: 'BigNumber'})
math.add('2', '3')
// results in a number with value 5, but should be a BigNumber with value 5

The reason is that functions like add do not have a signature like add(string, string). Therefore, automatic conversion kicks in. The automatic conversion finds a conversion from string -> number that fits the bill and uses that, without reconing with the configured config.number. I'm not sure how a proper solution to fix this would look like, since the type conversions are static 🤔.

貢獻者指南

技術棧
javascript
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Knowledge of mathjs configurationUnderstanding of function signatures
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate how mathjs functions handle argument type conversions, specifically in the `add` function. Look at the `conversion` module to understand how conversions are prioritized. Consider modifying the automatic conversion logic to respect `config.number` when converting strings to numeric types. The issue mentions that conversions are static, so a solution might involve dynamic conversion selection based on configuration.