jlfwong/speedscope

Optimize fallback path when TextDecoder is not available

開放

#189 建立於 2018年11月8日

 (0 則留言) (0 個反應) (0 位負責人)TypeScript (320 個分叉)batch import
good first issuehelp wanted

倉庫指標

星標
 (6,728 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

In https://github.com/jlfwong/speedscope/pull/188, I introduced TextDecoder as a way of avoiding performance issues with building up a huge string slowly. There are ways to make the fallback path faster and use less memory as well:

From @evanw:

The problem is that JavaScript JITs such as V8 optimize repeated string appends by building up a linked list in memory and only constructing the full string when the string is first used. So you probably want to periodically flatten the string in your loop to avoid running out of memory.

For future reference: one way to get Chrome to evaluate the string is to do str[0];. That doesn't appear to do anything but actually has the side effect of evaluating the string.

This fallback path is probably only used in Edge: https://caniuse.com/#feat=textencoder

貢獻者指南